cshuo commented on code in PR #20023:
URL: https://github.com/apache/hudi/pull/20023#discussion_r4071478305


##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/lsm/SpillableLsmRecordIterator.java:
##########
@@ -166,6 +166,13 @@ private void 
closeSourceIterator(ClosableIterator<BufferedRecord<T>> sourceItera
       if (spillFailure != null) {
         spillFailure.addSuppressed(e);
       } else {
+        // Closing the source iterator failed, so construction cannot complete 
and the outer reader

Review Comment:
   Tracked in #20025. I'll fix the initialization cleanup in a separate PR, 
including closing previously opened readers and cleaning up their spill files 
when a later reader fails to initialize.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to