zhangxinyao88 commented on code in PR #20020:
URL: https://github.com/apache/hudi/pull/20020#discussion_r4078931098
##########
packaging/hudi-gcp-bundle/pom.xml:
##########
@@ -99,7 +99,21 @@
<include>org.apache.hudi:hudi-hive-sync</include>
<include>org.apache.hudi:hudi-gcp</include>
<include>org.apache.parquet:parquet-avro</include>
- <include>com.google.cloud:google-cloud-bigquery</include>
+ <!-- Google Cloud SDK -->
+ <include>com.google.cloud:*</include>
Review Comment:
> The tree shows `com.google.guava:guava:31.1-jre`...
Added and relocated Guava, `failureaccess`, and `listenablefuture`. The
rebuilt bundle has no unrelocated Guava classes.
##########
packaging/hudi-gcp-bundle/pom.xml:
##########
@@ -99,7 +99,21 @@
<include>org.apache.hudi:hudi-hive-sync</include>
<include>org.apache.hudi:hudi-gcp</include>
<include>org.apache.parquet:parquet-avro</include>
- <include>com.google.cloud:google-cloud-bigquery</include>
+ <!-- Google Cloud SDK -->
+ <include>com.google.cloud:*</include>
+ <include>com.google.api:*</include>
+ <include>com.google.apis:*</include>
+ <include>com.google.api-client:*</include>
+ <include>com.google.api.grpc:*</include>
Review Comment:
> Was leaving the connector itself out intentional...?
The lock client uses `google-cloud-storage`, not the Hadoop GCS connector,
so I left that stack out.
##########
packaging/hudi-gcp-bundle/pom.xml:
##########
@@ -99,7 +99,21 @@
<include>org.apache.hudi:hudi-hive-sync</include>
<include>org.apache.hudi:hudi-gcp</include>
<include>org.apache.parquet:parquet-avro</include>
- <include>com.google.cloud:google-cloud-bigquery</include>
+ <!-- Google Cloud SDK -->
+ <include>com.google.cloud:*</include>
+ <include>com.google.api:*</include>
+ <include>com.google.apis:*</include>
+ <include>com.google.api-client:*</include>
+ <include>com.google.api.grpc:*</include>
+ <include>com.google.auth:*</include>
+ <include>com.google.code.gson:*</include>
+ <include>com.google.http-client:*</include>
+ <include>com.google.oauth-client:*</include>
+ <include>com.google.protobuf:*</include>
+ <include>io.grpc:*</include>
Review Comment:
> These broad wildcards make the bundle contents...
Narrowed this PR’s new wildcards; the existing broader Cloud/gRPC rules
predate this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
