zhangxinyao88 commented on code in PR #20020:
URL: https://github.com/apache/hudi/pull/20020#discussion_r4077848237
##########
packaging/hudi-gcp-bundle/pom.xml:
##########
@@ -99,7 +99,18 @@
<include>org.apache.hudi:hudi-hive-sync</include>
<include>org.apache.hudi:hudi-gcp</include>
<include>org.apache.parquet:parquet-avro</include>
- <include>com.google.cloud:google-cloud-bigquery</include>
+ <!-- Google Cloud SDK -->
+ <include>com.google.cloud:*</include>
+ <include>com.google.api:*</include>
Review Comment:
> `com.google.api:*` doesn't match
`com.google.apis:google-api-services-storage` (different groupId), and
`com.google.code.gson:gson` / `org.threeten:threetenbp` are also outside the
allowlist.
Good catch. I added explicit includes for all three. The existing
lock-provider test is disabled, so I’ll validate runtime initialization
separately.
##########
packaging/hudi-gcp-bundle/pom.xml:
##########
@@ -99,7 +99,18 @@
<include>org.apache.hudi:hudi-hive-sync</include>
<include>org.apache.hudi:hudi-gcp</include>
<include>org.apache.parquet:parquet-avro</include>
- <include>com.google.cloud:google-cloud-bigquery</include>
+ <!-- Google Cloud SDK -->
+ <include>com.google.cloud:*</include>
+ <include>com.google.api:*</include>
+ <include>com.google.api-client:*</include>
+ <include>com.google.api.grpc:*</include>
+ <include>com.google.auth:*</include>
+ <include>com.google.http-client:*</include>
+ <include>com.google.oauth-client:*</include>
+ <include>com.google.protobuf:*</include>
Review Comment:
> Have you considered relocating these (e.g. to
`org.apache.hudi.com.google.protobuf` / `org.apache.hudi.io.grpc`)?
This is a real compatibility risk. I left relocation out of this change
because it needs a broader bundle-policy decision. @yihua, do you think this
bundle should relocate protobuf and gRPC?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
