hudi-agent commented on code in PR #19944:
URL: https://github.com/apache/hudi/pull/19944#discussion_r4049056771
##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/utils/HoodieInputFormatUtils.java:
##########
@@ -495,19 +495,19 @@ public static HoodieMetadataConfig
buildMetadataConfig(Configuration conf) {
* 3. Generation of splits looks at FileStatus size to create splits, which
skips this file
*
* @param conf
- * @param dataFile
+ * @param baseFile
* @return
*/
- private static HoodieBaseFile refreshFileStatus(Configuration conf,
HoodieBaseFile dataFile) {
- StoragePath dataPath = dataFile.getPathInfo().getPath();
+ private static HoodieBaseFile refreshFileStatus(Configuration conf,
HoodieBaseFile baseFile) {
+ StoragePath dataPath = baseFile.getPathInfo().getPath();
Review Comment:
🤖 nit: since the param is now `baseFile`, it might be worth renaming
`dataPath` to `baseFilePath` too so the method uses one term throughout.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
