nanjeshramesh commented on PR #19944: URL: https://github.com/apache/hudi/pull/19944#issuecomment-5733549095
Addressed in e0ba874. Both hudi-agent nits (CompactionAdminClient and TestHoodieCompactionStrategy) flagged the same inconsistency: I'd used the abbreviated `bf` for some lambda parameters and locals while using the full `baseFile` elsewhere. Rather than fix only those two spots, I converted every `bf` this PR had introduced, across all 8 files (also AbstractTableFileSystemView, IncrementalTimelineSyncFileSystemView, RocksDbBasedFileSystemView, TestCleanerInsertAndCleanByVersions, TestHoodieTableFileSystemView, and TestCompactionUtils), so the whole change now uses `baseFile` uniformly. Test-compiled hudi-common, hudi-hadoop-common, hudi-client-common, and hudi-spark-client against JDK 11 with no errors, including no lambda-parameter shadowing conflicts. On the Codecov patch-coverage note: those flagged lines are all pure renames of parameters and locals that were equally uncovered before and after, so the project-wide delta is -0.01% and no behavior or coverage actually changed. Happy to add anything if you'd still like it, but I didn't think new tests for a rename made sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
