fhan688 commented on PR #19226: URL: https://github.com/apache/hudi/pull/19226#issuecomment-5029793818
> > Therefore I should remove hasLaterDeltaCommits and its test, while leaving the existing restore behavior unchanged. Is that correct? > > for rollback, each instant would be rolled back separately, so just take care of the current instant rollback should be fine, the fix from the patch is on the rollback path instead of restore already, if move forward like you said, the logic would be the same with master, is the fix still necessary. You are right. Since rollback handles each instant separately, the existing master behavior for regular compaction rollback is already correct. The remaining hasLaterDeltaCommits change attempts to handle files owned by another instant and is not a valid fix. Thanks, I'll close this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
