fhan688 commented on PR #19226: URL: https://github.com/apache/hudi/pull/19226#issuecomment-5021317578
> > The rollback now preserves log files while a later delta commit still exists, but deletes the full compaction file slice once that later delta instant has been removed, preventing orphan log files after the compaction base file is rolled back. > > still didn't get it, the orphan log files should be taken care by their corresponding instant rollback right? For rollback of the compaction itself, the current behavior is correct. And the orphan log files would finally been cleaned when the heartbeat timedout. Thanks, to confirm my understanding: for a regular non-restore compaction rollback, we should always keep the existing behavior of deleting only the compaction-generated base files, regardless of whether later delta instants are still present. Log files written by later delta commits belong to those delta instants and should be handled by their rollback or heartbeat-timeout cleanup. Therefore I should remove hasLaterDeltaCommits and its test, while leaving the existing restore behavior unchanged. Is that correct? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
