voonhous commented on code in PR #19158:
URL: https://github.com/apache/hudi/pull/19158#discussion_r3522943228
##########
hudi-common/src/test/java/org/apache/hudi/common/testutils/minicluster/ZookeeperTestService.java:
##########
@@ -217,7 +217,7 @@ private static boolean waitForServerUp(String hostname, int
port, long timeout)
}
} catch (IOException e) {
// ignore as this is expected
- log.info("server " + hostname + ":" + port + " not up " + e);
+ log.info("server {}:{} not up {}", hostname, port, e.toString());
Review Comment:
This one's intentional. `e` is the last argument and there are three `{}`
placeholders. SLF4J's `MessageFormatter` treats a trailing `Throwable` as the
stacktrace arg: it peels `e` off the substitution list, so bare `e` would leave
the third `{}` unfilled in the message *and* append a full stack trace - on a
path that is explicitly `// ignore as this is expected` and runs in a tight
startup-polling retry loop.
`e.toString()` forces it to a `String` so it stays a plain value for the
third placeholder, matching the original inline output. Keeping as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
