hudi-agent commented on code in PR #19158:
URL: https://github.com/apache/hudi/pull/19158#discussion_r3521281297
##########
hudi-common/src/test/java/org/apache/hudi/common/testutils/minicluster/ZookeeperTestService.java:
##########
@@ -217,7 +217,7 @@ private static boolean waitForServerUp(String hostname, int
port, long timeout)
}
} catch (IOException e) {
// ignore as this is expected
- log.info("server " + hostname + ":" + port + " not up " + e);
+ log.info("server {}:{} not up {}", hostname, port, e.toString());
Review Comment:
🤖 nit: the explicit `.toString()` call is redundant here — SLF4J's
parameterized logging calls `toString()` on arguments internally, so `e` alone
would produce the same output and reads more naturally.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
