danny0405 commented on code in PR #18350:
URL: https://github.com/apache/hudi/pull/18350#discussion_r3049177164
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseRollbackActionExecutor.java:
##########
@@ -266,7 +266,7 @@ protected List<HoodieRollbackStat>
executeRollback(HoodieInstant instantToRollba
}
protected void finishRollback(HoodieInstant inflightInstant,
HoodieRollbackMetadata rollbackMetadata) throws HoodieIOException {
- boolean enableLocking = (!skipLocking && !skipTimelinePublish);
+ boolean enableLocking = (!skipLocking || !skipTimelinePublish);
Review Comment:
it's a bug gix, the follwing-up upsert into MDT needs a lock anyway when
`!skipTimelinePublish` is true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
