danny0405 commented on code in PR #18350:
URL: https://github.com/apache/hudi/pull/18350#discussion_r3049173396
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanActionExecutor.java:
##########
@@ -226,11 +227,11 @@ private HoodieCleanMetadata runClean(HoodieTable<T, I, K,
O> table, HoodieInstan
);
this.txnManager.beginStateChange(Option.of(inflightInstant),
Option.empty());
writeTableMetadata(metadata, inflightInstant.requestedTime());
- table.getActiveTimeline().transitionCleanInflightToComplete(
- false,
- inflightInstant,
- Option.of(metadata),
- completedInstant ->
table.getMetaClient().getTableFormat().clean(metadata, completedInstant,
table.getContext(), table.getMetaClient(), table.getViewManager()));
+ TableFormatCompletionAction formatCompletionAction = completedInstant ->
table.getMetaClient().getTableFormat()
+ .clean(metadata, completedInstant, table.getContext(),
table.getMetaClient(), table.getViewManager());
+ HoodieInstant completedInstant =
table.getActiveTimeline().transitionCleanInflightToComplete(inflightInstant,
Option.of(metadata), txnManager.generateInstantTime());
+ // FIXME-vc: this is an one off..
+ formatCompletionAction.execute(completedInstant);
log.info("Marked clean started on {} as complete",
inflightInstant.requestedTime());
Review Comment:
not sure what it means for `one off...`, the APi
`transitionCleanInflightToComplete` accpects an explicit completion action.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
