kbuci commented on code in PR #18302:
URL: https://github.com/apache/hudi/pull/18302#discussion_r2943911406
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java:
##########
@@ -974,17 +981,18 @@ protected Map<String, Option<HoodiePendingRollbackInfo>>
getPendingRollbackInfos
String action = rollbackPlan.getInstantToRollback().getAction();
String instantToRollback =
rollbackPlan.getInstantToRollback().getCommitTime();
if (ignoreCompactionAndClusteringInstants) {
- if (!HoodieTimeline.COMPACTION_ACTION.equals(action)) {
- InstantGenerator instantGenerator =
metaClient.getInstantGenerator();
- boolean isClustering =
ClusteringUtils.isClusteringInstant(metaClient.getActiveTimeline(),
-
instantGenerator.createNewInstant(HoodieInstant.State.INFLIGHT, action,
instantToRollback), instantGenerator);
- if (!isClustering) {
- infoMap.putIfAbsent(instantToRollback, Option.of(new
HoodiePendingRollbackInfo(rollbackInstant, rollbackPlan)));
- }
+ if (HoodieTimeline.COMPACTION_ACTION.equals(action)) {
+ continue;
+ }
+ HoodieInstant instant = metaClient.getInstantGenerator()
+ .createNewInstant(HoodieInstant.State.INFLIGHT, action,
instantToRollback);
+ if (!isClusteringInstantEligibleForRollback(metaClient, instant)
Review Comment:
Sure, I refactored it to not need any continue and to be closer to original
approach
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
