kbuci commented on code in PR #18295:
URL: https://github.com/apache/hudi/pull/18295#discussion_r2914266060
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -2143,15 +2145,24 @@ static HoodieActiveTimeline
runPendingTableServicesOperationsAndRefreshTimeline(
Option<HoodieMetadataMetrics> metricsOption) {
try {
HoodieActiveTimeline activeTimeline = initialTimelineRequiresRefresh ?
metadataMetaClient.reloadActiveTimeline() :
metadataMetaClient.getActiveTimeline();
+ HoodieTableServiceManagerConfig tsmConfig =
writeClient.getConfig().getTableServiceManagerConfig();
// finish off any pending log compaction or compactions operations if
any from previous attempt.
boolean ranServices = false;
if (activeTimeline.filterPendingCompactionTimeline().countInstants() >
0) {
- writeClient.runAnyPendingCompactions();
- ranServices = true;
+ if (tsmConfig.isEnabledAndActionSupported(ActionType.compaction)) {
Review Comment:
In our org's internal build we have a separate config for "disabling"
compaction/logcompaction inline. But since it seems in OSS we use
HoodieTableServiceManagerConfig for data table, I decided to stick with that
usage/convention
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
