danny0405 commented on code in PR #13729:
URL: https://github.com/apache/hudi/pull/13729#discussion_r2281250757
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/FileGroupReaderBasedMergeHandle.java:
##########
@@ -401,6 +404,11 @@ public void onDelete(String recordKey, BufferedRecord<T>
previousRecord, HoodieO
cdcLogger.put(recordKey, convertOutput(previousRecord), Option.empty());
}
+ @Override
+ public void onFailure(String recordKey) {
+ cdcLogger.remove(recordKey);
Review Comment:
cdc logging also needs retraction so I moved the retraction interface to
just `BaseFileUpdateCallback`, but I didn't have a chance to add a test for it
yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
