the-other-tim-brown commented on code in PR #13694:
URL: https://github.com/apache/hudi/pull/13694#discussion_r2265018860
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/cdc/CDCFileGroupIterator.scala:
##########
@@ -540,15 +551,24 @@ class CDCFileGroupIterator(split: HoodieCDCFileGroupSplit,
convertToUTF8String(HoodieCDCUtils.recordToJson(record))
}
- private def merge(currentRecord: InternalRow, newRecord: InternalRow):
ImmutablePair[HoodieSparkRecord, Schema] = {
- recordMerger.merge(new HoodieSparkRecord(currentRecord, structTypeSchema),
avroSchema,
- new HoodieSparkRecord(newRecord, structTypeSchema), avroSchema, props)
- .get().asInstanceOf[ImmutablePair[HoodieSparkRecord, Schema]]
+ private def merge(currentRecord: BufferedRecord[InternalRow], newRecord:
BufferedRecord[InternalRow]): BufferedRecord[InternalRow] = {
+ if (!isPartialMergeEnabled && keyBasedFileGroupRecordBuffer.isPresent &&
keyBasedFileGroupRecordBuffer.get().isPartialMergingEnabled) {
Review Comment:
ok, I think we're good to match the existing behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
