jonvex commented on code in PR #13694:
URL: https://github.com/apache/hudi/pull/13694#discussion_r2264847458
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReader.java:
##########
@@ -280,11 +280,17 @@ public void close() throws IOException {
}
}
+ // don't make this public because caller is expected to set the iterator mode
Review Comment:
Would it be better just to add iterator mode as a param and then set it in
this method? So caller is forced to decide?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
