lokeshj1703 commented on code in PR #13526:
URL: https://github.com/apache/hudi/pull/13526#discussion_r2225497977
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java:
##########
@@ -814,7 +814,7 @@ public String getRecordMergeStrategyId() {
public static Triple<RecordMergeMode, String, String>
inferCorrectMergingBehavior(RecordMergeMode recordMergeMode,
String payloadClassName,
String recordMergeStrategyId,
-
String orderingFieldName,
+
String orderingFieldNames,
Review Comment:
We only check if the preCombine fields are set in this function. So do not
require a list here. Renamed to orderingFieldNamesAsString to make it more
clear.
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java:
##########
@@ -926,8 +926,12 @@ static RecordMergeMode
inferRecordMergeModeFromMergeStrategyId(String recordMerg
}
}
- public String getPreCombineField() {
- return getString(PRECOMBINE_FIELD);
+ public Option<List<String>> getPreCombineFieldList() {
Review Comment:
Addressed. Also renamed `PRECOMBINE_FIELD` to `PRECOMBINE_FIELDS`
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java:
##########
@@ -1153,8 +1153,8 @@ public TableBuilder setBaseFileFormat(String
baseFileFormat) {
return this;
}
- public TableBuilder setPreCombineField(String preCombineField) {
- this.preCombineField = preCombineField;
+ public TableBuilder setPreCombineFields(String preCombineField) {
Review Comment:
This string is a comma separated combination of fields. Added docs to make
it more clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
