lokeshj1703 commented on code in PR #13526:
URL: https://github.com/apache/hudi/pull/13526#discussion_r2225404302
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/block/HoodieDeleteBlock.java:
##########
@@ -142,11 +142,18 @@ private byte[] serializeV3() throws IOException {
HoodieDeleteRecordList.Builder recordListBuilder =
HOODIE_DELETE_RECORD_LIST_BUILDER_STUB.get();
HoodieDeleteRecord.Builder recordBuilder =
HOODIE_DELETE_RECORD_BUILDER_STUB.get();
List<HoodieDeleteRecord> deleteRecordList =
Arrays.stream(getRecordsToDelete())
- .map(record -> HoodieDeleteRecord.newBuilder(recordBuilder)
+ .map(record -> {
+ List<Comparable> orderingVals = record.getOrderingValue() instanceof
Comparables
Review Comment:
This is taken care of in recent commits made by Danny
##########
hudi-common/src/main/java/org/apache/hudi/common/engine/HoodieReaderContext.java:
##########
@@ -479,6 +481,15 @@ public final UnaryOperator<T> projectRecord(Schema from,
Schema to) {
return projectRecord(from, to, Collections.emptyMap());
}
+ /**
+ * Converts the comparable values in Comparables to the specific engine type
+ */
+ public final Comparable convertValueToEngineType(Comparable value) {
+ return value instanceof Comparables
Review Comment:
This is taken care of in recent commits made by Danny
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
