cshuo commented on code in PR #13536:
URL: https://github.com/apache/hudi/pull/13536#discussion_r2203665670
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/action/compact/CompactionTestBase.java:
##########
@@ -140,9 +146,11 @@ protected List<HoodieRecord>
runNextDeltaCommits(SparkRDDWriteClient client, fin
assertNoWriteErrors(statusList);
metaClient = createMetaClient(cfg.getBasePath());
HoodieTable hoodieTable = getHoodieTable(metaClient, cfg);
- List<HoodieBaseFile> dataFilesToRead =
getCurrentLatestBaseFiles(hoodieTable);
- assertTrue(dataFilesToRead.stream().findAny().isPresent(),
- "should list the base files we wrote in the delta commit");
+ if (hasBaseFile) {
Review Comment:
> I'm actually trying to reproduce the corner case in
https://github.com/apache/hudi/issues/13534, where there is no base file for a
file slice, and all logs are filtered out by complete time.
@yihua I previously added a separate UT for the above case, and removed it
since the changes can be covered by the existing test case
`TestAsyncCompaction#testScheduleCompactionWithOlderOrSameTimestamp` after
adding validating check in `CompactionOperation`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
