danny0405 commented on code in PR #13536:
URL: https://github.com/apache/hudi/pull/13536#discussion_r2196719032


##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/action/compact/CompactionTestBase.java:
##########
@@ -140,9 +146,11 @@ protected List<HoodieRecord> 
runNextDeltaCommits(SparkRDDWriteClient client, fin
       assertNoWriteErrors(statusList);
       metaClient = createMetaClient(cfg.getBasePath());
       HoodieTable hoodieTable = getHoodieTable(metaClient, cfg);
-      List<HoodieBaseFile> dataFilesToRead = 
getCurrentLatestBaseFiles(hoodieTable);
-      assertTrue(dataFilesToRead.stream().findAny().isPresent(),
-          "should list the base files we wrote in the delta commit");
+      if (hasBaseFile) {

Review Comment:
   The base file existence is not very related with the fix, we can still 
generate base files for insert, and schedule compaction for logs(with a 
timestamp greater than the insert and small than delta instants).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to