lokeshj1703 commented on code in PR #13449:
URL: https://github.com/apache/hudi/pull/13449#discussion_r2160996074
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1202,6 +1228,7 @@ private HoodieData<WriteStatus>
prepareAndWriteToNonStreamingPartitions(HoodieCo
private Set<String> getNonStreamingMetadataPartitionsToUpdate() {
Set<String> toReturn =
enabledPartitionTypes.stream().map(MetadataPartitionType::getPartitionPath).collect(Collectors.toSet());
STREAMING_WRITES_SUPPORTED_PARTITIONS.forEach(metadataPartitionType ->
toReturn.remove(metadataPartitionType.getPartitionPath()));
+
STREAMING_WRITES_SUPPORTED_PARTITION_PREFIXES.forEach(metadataPartitionType ->
toReturn.remove(metadataPartitionType.getPartitionPath()));
Review Comment:
The problem with static list is that there will be two source of truths
then. If in future, we miss updating one of the lists it can create unnecessary
issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
