danny0405 commented on code in PR #13449:
URL: https://github.com/apache/hudi/pull/13449#discussion_r2159824494
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java:
##########
@@ -226,6 +231,11 @@ private Option<FileSlice>
populateWriteStatAndFetchFileSlice(HoodieRecord record
return fileSlice;
}
+ private Option<FileSlice> getFileSlice() {
+ TableFileSystemView.SliceView rtView = hoodieTable.getSliceView();
+ return rtView.getLatestFileSlice(partitionPath, fileId);
Review Comment:
be cautious about this change, the `#getLatestMergedFileSlicesBeforeOrOn`
will return a different base instant time there, while the CDC always requires
the latest base instant time to trace the changes base for reader.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
