the-other-tim-brown commented on code in PR #13449: URL: https://github.com/apache/hudi/pull/13449#discussion_r2159547739
########## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieWriteHandle.java: ########## @@ -81,18 +86,24 @@ public abstract class HoodieWriteHandle<T, I, K, O> extends HoodieIOHandle<T, I, protected final TaskContextSupplier taskContextSupplier; // For full schema evolution protected final boolean schemaOnReadEnabled; + protected final boolean preserveMetadata; + /** + * Flag saying whether secondary index streaming writes is enabled for the table. + */ + protected final boolean isSecondaryIndexStatsStreamingWritesEnabled; + List<Pair<String, HoodieIndexDefinition>> secondaryIndexDefns = Collections.emptyList(); Review Comment: The List is now `final` and always empty, this seems like a bug -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
