the-other-tim-brown commented on code in PR #13451:
URL: https://github.com/apache/hudi/pull/13451#discussion_r2159207303
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/WriteClientTestUtils.java:
##########
@@ -40,4 +43,22 @@ public static void
startCommitWithTime(BaseHoodieWriteClient<?, ?, ?, ?> writeCl
public static Option<String> scheduleTableService(BaseHoodieWriteClient<?,
?, ?, ?> writeClient, String instantTime, Option<Map<String, String>>
extraMetadata, TableServiceType tableServiceType) {
return writeClient.scheduleTableService(Option.of(instantTime),
extraMetadata, tableServiceType);
}
+
+ public static String createNewInstantTime() {
+ return HoodieInstantTimeGenerator.createNewInstantTime(false,
TestTimeGenerator.INSTANCE, 0);
Review Comment:
This path has the added benefit of ensuring that the instant times are
unique by going through the checks in `HoodieInstantTimeGenerator`. Without
this, there is some flakiness in the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
