danny0405 commented on code in PR #13451:
URL: https://github.com/apache/hudi/pull/13451#discussion_r2155768001
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/WriteClientTestUtils.java:
##########
@@ -40,4 +43,22 @@ public static void
startCommitWithTime(BaseHoodieWriteClient<?, ?, ?, ?> writeCl
public static Option<String> scheduleTableService(BaseHoodieWriteClient<?,
?, ?, ?> writeClient, String instantTime, Option<Map<String, String>>
extraMetadata, TableServiceType tableServiceType) {
return writeClient.scheduleTableService(Option.of(instantTime),
extraMetadata, tableServiceType);
}
+
+ public static String createNewInstantTime() {
+ return HoodieInstantTimeGenerator.createNewInstantTime(false,
TestTimeGenerator.INSTANCE, 0);
Review Comment:
Just use `HoodieInstantTimeGenerator.getCurrentInstantTimeStr` to avoid the
fake `TestTimeGenerator`?
Maybe just remove the `createNewInstantTime` here and just uses
`HoodieInstantTimeGenerator.getCurrentInstantTimeStr` directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
