the-other-tim-brown commented on code in PR #13451:
URL: https://github.com/apache/hudi/pull/13451#discussion_r2154484150
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1789,12 +1789,10 @@ void compactIfNecessary(BaseHoodieWriteClient<?,I,?,O>
writeClient, Option<Strin
writeClient.compact(compactionInstantTime, true);
} else if (metadataWriteConfig.isLogCompactionEnabled()) {
// Schedule and execute log compaction with new instant time.
- final String logCompactionInstantTime =
metadataMetaClient.createNewInstantTime(false);
- if
(metadataMetaClient.getActiveTimeline().filterCompletedInstants().containsInstant(logCompactionInstantTime))
{
- LOG.info("Log compaction with same {} time is already present in the
timeline.", logCompactionInstantTime);
Review Comment:
The time is now generated in this
[part](https://github.com/apache/hudi/blob/master/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java#L684)
of the code and the time is generated in the write client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
