vinothchandar commented on code in PR #13451:
URL: https://github.com/apache/hudi/pull/13451#discussion_r2153758997
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieInstantTimeGenerator.java:
##########
@@ -156,7 +156,7 @@ public static String
getInstantFromTemporalAccessor(TemporalAccessor temporalAcc
return MILLIS_INSTANT_TIME_FORMATTER.format(temporalAccessor);
}
- public static String getCurrentInstantTimeStr() {
+ public static String getCurrentTimeAsString() {
Review Comment:
rename: currentInstantTimeString()
I prefer to keep the intent of using this as instant time - with the name..
"CurrentTime" makes it less obvious at call sites.
##########
hudi-hadoop-common/src/test/java/org/apache/hudi/common/table/timeline/TestHoodieActiveTimeline.java:
##########
@@ -707,42 +701,6 @@ public void testReplaceActionsTimeline() {
timeline.getCommitTimeline().getInstantsAsStream(), "Check the
instants stream");
}
- @Test
- public void testCreateNewInstantTime() throws Exception {
Review Comment:
similar, can this be fixed/moved some place else
##########
hudi-hadoop-common/src/test/java/org/apache/hudi/common/table/TestHoodieTableMetaClient.java:
##########
@@ -128,38 +124,6 @@ public void testCommitTimeline() throws IOException {
assertEquals("val",
metaClient.getActiveTimeline().readCommitMetadata(completedInstant).getExtraMetadata().get("key"));
}
- @Test
Review Comment:
Add these tests to TimeGenerator or a relevant place?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1789,12 +1789,10 @@ void compactIfNecessary(BaseHoodieWriteClient<?,I,?,O>
writeClient, Option<Strin
writeClient.compact(compactionInstantTime, true);
} else if (metadataWriteConfig.isLogCompactionEnabled()) {
// Schedule and execute log compaction with new instant time.
- final String logCompactionInstantTime =
metadataMetaClient.createNewInstantTime(false);
- if
(metadataMetaClient.getActiveTimeline().filterCompletedInstants().containsInstant(logCompactionInstantTime))
{
- LOG.info("Log compaction with same {} time is already present in the
timeline.", logCompactionInstantTime);
Review Comment:
is this case now handled within writeClient.schedule.... ? I peeked
quickly.. writeClient delegates to the table obj
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
