the-other-tim-brown commented on code in PR #13411:
URL: https://github.com/apache/hudi/pull/13411#discussion_r2152349565
##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieAvroRecord.java:
##########
@@ -168,6 +182,8 @@ public boolean isDelete(Schema recordSchema, Properties
props) throws IOExceptio
}
if (this.data instanceof BaseAvroPayload) {
return ((BaseAvroPayload) this.data).isDeleted(recordSchema, props);
+ } else if (this.data instanceof HoodieMetadataPayload) {
Review Comment:
I've been looking for a good place to put this interface and could not find
a good one without too much refactoring. I agree with @danny0405 that we should
do this when refactoring when deprecating payload.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
