the-other-tim-brown commented on code in PR #13408: URL: https://github.com/apache/hudi/pull/13408#discussion_r2139048152
########## hudi-common/src/main/java/org/apache/hudi/common/serialization/RecordSerializer.java: ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.common.serialization; + +import java.io.Serializable; + +/** + * Serializer for engine-specific record, e.g., {@code InternalRow} in Spark, + * {@code RowData} in Flink and {@code IndexedRecord} for Avro. + */ +public interface RecordSerializer<T> extends Serializable { Review Comment: This is very similar to the interface we already have, `CustomSerializer`. I'm guessing we can't consolidate due to the deserializer needing a schema? The records in the spillable map should all have the same schema since we read the log records with the projected schema from the log files so maybe we don't need that `schemaId`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
