cshuo commented on code in PR #13408:
URL: https://github.com/apache/hudi/pull/13408#discussion_r2139039505
##########
hudi-common/src/main/java/org/apache/hudi/common/engine/HoodieReaderContext.java:
##########
@@ -183,6 +187,14 @@ public Option<Predicate> getKeyFilterOpt() {
return keyFilterOpt;
}
+ public SizeEstimator<BufferedRecord<T>> getRecordSizeEstimator() {
+ return new HoodieRecordSizeEstimator<>(schemaHandler.getRequiredSchema());
+ }
+
+ public CustomSerializer<BufferedRecord<T>> getRecordSerializer() {
+ return new DefaultSerializer<>();
Review Comment:
> use BufferedRecordSerializer with the DefaultSerializer
Currently the inner serializer of `BufferedRecordSerializer` is the new
added interface`RecordSerializer`, I guess you mean using
BufferedRecordSerializer with the default implementation of `RecordSerializer`.
> specialized handler of the BufferedRecord will help with general
performance.
One clear benefit is the size of serialized bytes will be smaller for
`BufferedRecordSerializer` comparing with `DefaultSerializer `.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
