vamsikarnika commented on code in PR #13384:
URL: https://github.com/apache/hudi/pull/13384#discussion_r2132130064
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/BufferedRecord.java:
##########
@@ -77,6 +77,10 @@ public static <T> BufferedRecord<T>
forDeleteRecord(DeleteRecord deleteRecord, C
return new BufferedRecord<>(deleteRecord.getRecordKey(), orderingValue,
null, null, true);
}
+ public static <T> BufferedRecord<T> forDeleteRecord(String recordKey,
Comparable orderingValue) {
+ return new BufferedRecord<>(recordKey, orderingValue, null, null, true);
Review Comment:
Hi Danny, In this particular scenario. In the first commit we write a data
block in metadata table which says file#1 and file#2 are added. In the second
commit we write a new data block that says file#1 and file#2 are deleted. Both
are data blocks only, but onlu upon merging the both the blocks we're
considering them as delete record. So I don't think writing to delete block
works here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
