danny0405 commented on code in PR #13384:
URL: https://github.com/apache/hudi/pull/13384#discussion_r2127777882
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/BufferedRecord.java:
##########
@@ -77,6 +77,10 @@ public static <T> BufferedRecord<T>
forDeleteRecord(DeleteRecord deleteRecord, C
return new BufferedRecord<>(deleteRecord.getRecordKey(), orderingValue,
null, null, true);
}
+ public static <T> BufferedRecord<T> forDeleteRecord(String recordKey,
Comparable orderingValue) {
+ return new BufferedRecord<>(recordKey, orderingValue, null, null, true);
Review Comment:
-1, don't think it is reasonable to generate a delete buffer record from
just a record key here, the deletes should always be written into the delete
data block which would finally be deserialized into a `DeleteRecord`, if it is
not, please fix either the payload class or the merger impl.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
