the-other-tim-brown commented on code in PR #13340:
URL: https://github.com/apache/hudi/pull/13340#discussion_r2110770045
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanPlanActionExecutor.java:
##########
@@ -53,16 +53,15 @@
import static org.apache.hudi.common.util.MapUtils.nonEmpty;
public class CleanPlanActionExecutor<T, I, K, O> extends BaseActionExecutor<T,
I, K, O, Option<HoodieCleanerPlan>> {
-
+ public static final HoodieCleanerPlan EMPTY_CLEANER_PLAN = new
HoodieCleanerPlan();
private static final Logger LOG =
LoggerFactory.getLogger(CleanPlanActionExecutor.class);
private final Option<Map<String, String>> extraMetadata;
public CleanPlanActionExecutor(HoodieEngineContext context,
HoodieWriteConfig config,
HoodieTable<T, I, K, O> table,
- String instantTime,
Option<Map<String, String>> extraMetadata) {
- super(context, config, table, instantTime);
+ super(context, config, table, null);
Review Comment:
This was bothering me as well, I don't think there is any need for the
planner to extend this base class so another option is to remove that so there
is no call the `super`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
