the-other-tim-brown commented on code in PR #13340:
URL: https://github.com/apache/hudi/pull/13340#discussion_r2110741668
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java:
##########
@@ -543,16 +543,14 @@ public abstract Option<HoodieClusteringPlan>
scheduleClustering(HoodieEngineCont
public abstract void rollbackBootstrap(HoodieEngineContext context, String
instantTime);
/**
- * Schedule cleaning for the instant time.
+ * Generates a cleaner plan if required.
*
- * @param context HoodieEngineContext
- * @param instantTime Instant Time for scheduling cleaning
+ * @param context HoodieEngineContext
* @param extraMetadata additional metadata to write into plan
* @return HoodieCleanerPlan, if there is anything to clean.
*/
- public abstract Option<HoodieCleanerPlan>
scheduleCleaning(HoodieEngineContext context,
- String
instantTime,
-
Option<Map<String, String>> extraMetadata);
+ public abstract Option<HoodieCleanerPlan>
createCleanerPlan(HoodieEngineContext context,
Review Comment:
The rollback/restore is going to be covered in another PR
(https://issues.apache.org/jira/browse/HUDI-9421)
Just created a separate task in the story for the indexing which was not on
my radar originally (https://issues.apache.org/jira/browse/HUDI-9471)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
