danny0405 commented on code in PR #13300:
URL: https://github.com/apache/hudi/pull/13300#discussion_r2105627833
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReader.java:
##########
@@ -237,7 +238,9 @@ private ClosableIterator<T> makeBaseFileIterator() throws
IOException {
readerContext.getSchemaHandler().getTableSchema(),
readerContext.getSchemaHandler().getRequiredSchema(), storage);
}
- return readerContext.getInstantRange().isPresent() ?
readerContext.applyInstantRangeFilter(recordIterator) : recordIterator;
+ return readerContext.getInstantRange().isPresent() &&
!isMdtBaseFile(baseFile)
Review Comment:
My intention is we add a special flag for this special case for MDT, but I
think it is okay for this now.
> My question here is: when should we do instantRange check, when shouldn't?
generally we should always do the instant range check if it is specified,
the MDT case is rare.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
