linliu-code commented on code in PR #13300:
URL: https://github.com/apache/hudi/pull/13300#discussion_r2105483616
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReader.java:
##########
@@ -237,7 +238,9 @@ private ClosableIterator<T> makeBaseFileIterator() throws
IOException {
readerContext.getSchemaHandler().getTableSchema(),
readerContext.getSchemaHandler().getRequiredSchema(), storage);
}
- return readerContext.getInstantRange().isPresent() ?
readerContext.applyInstantRangeFilter(recordIterator) : recordIterator;
+ return readerContext.getInstantRange().isPresent() &&
!isMdtBaseFile(baseFile)
Review Comment:
@danny0405 , as you suggested, InstantRange skips MDT base file.
My question here is: when should we do instantRange check, when shouldn't?
We may need some document for this clearly for future reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
