danny0405 commented on code in PR #13229:
URL: https://github.com/apache/hudi/pull/13229#discussion_r2101425069
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/action/rollback/TestCopyOnWriteRollbackActionExecutor.java:
##########
@@ -215,27 +219,34 @@ public void testListBasedRollbackStrategy() throws
Exception {
// Verify that rollback works with replacecommit
@ParameterizedTest
@ValueSource(booleans = {true, false})
- public void testCopyOnWriteRollbackWithReplaceCommits(boolean
isUsingMarkers) throws IOException {
+ public void testCopyOnWriteRollbackWithReplaceCommits(boolean
isUsingMarkers) throws IOException, InterruptedException {
//1. prepare data and assert data result
List<FileSlice> firstPartitionCommit2FileSlices = new ArrayList<>();
List<FileSlice> secondPartitionCommit2FileSlices = new ArrayList<>();
- HoodieWriteConfig cfg =
getConfigBuilder().withRollbackUsingMarkers(isUsingMarkers).withAutoCommit(false).build();
-
this.insertOverwriteCommitDataWithTwoPartitions(firstPartitionCommit2FileSlices,
secondPartitionCommit2FileSlices, cfg, !isUsingMarkers);
+ HoodieWriteConfig cfg = getConfigBuilder()
+ .withRollbackUsingMarkers(isUsingMarkers)
+
.withFileSystemViewConfig(FileSystemViewStorageConfig.newBuilder().withRemoteTimelineClientRetry(true).build())
+ .build();
+ SparkRDDWriteClient client = getHoodieWriteClient(cfg);
Review Comment:
use `try` resource clause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
