danny0405 commented on code in PR #13229:
URL: https://github.com/apache/hudi/pull/13229#discussion_r2078722683
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -1092,28 +1092,20 @@ public HoodieWriteMetadata<O> compact(String
compactionInstantTime) {
if (shouldDelegateToTableServiceManager(config, ActionType.compaction)) {
throw new UnsupportedOperationException("Compaction should be delegated
to table service manager instead of direct run.");
}
- return compact(compactionInstantTime, config.shouldAutoCommit());
- }
-
- /**
- * Commit a compaction operation. Allow passing additional meta-data to be
stored in commit instant file.
- *
- * @param compactionInstantTime Compaction Instant Time
- * @param metadata All the metadata that gets stored along with a commit
- * @param extraMetadata Extra Metadata to be stored
- */
- public void commitCompaction(String compactionInstantTime,
HoodieCommitMetadata metadata,
- Option<Map<String, String>> extraMetadata) {
- tableServiceClient.commitCompaction(compactionInstantTime, metadata,
extraMetadata);
+ return compact(compactionInstantTime, false);
Review Comment:
I also feel like it's dangerous to switch the default `shouldComplete` from
`true` to `false`, It makes sense we remove the autoCommit stuff from
executors, but I kind of think we can support auto-commit as public APIs in
write client based on the fact we have so many use cases for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
