nsivabalan commented on code in PR #13229:
URL: https://github.com/apache/hudi/pull/13229#discussion_r2078710777
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/metadata/FlinkHoodieBackedTableMetadataWriter.java:
##########
@@ -199,6 +199,18 @@ protected HoodieData<HoodieRecord>
getExpressionIndexRecords(List<Pair<String, P
throw new HoodieNotSupportedException("Flink metadata table does not
support expression index yet.");
}
+ protected void bulkInsertAndCommit(BaseHoodieWriteClient<?,
List<HoodieRecord>, ?, List<WriteStatus>> writeClient, String instantTime,
List<HoodieRecord> preppedRecordInputs,
+ Option<BulkInsertPartitioner>
bulkInsertPartitioner) {
+ List<WriteStatus> writeStatusJavaRDD =
writeClient.bulkInsertPreppedRecords(preppedRecordInputs, instantTime,
bulkInsertPartitioner);
+ writeClient.commit(instantTime, writeStatusJavaRDD);
Review Comment:
these are public apis right. why add additional overloaded method that can
auto commit.
lets keep it clean.
only option for the user of WriteClient is to call writeClient.commit()
except few cases (bootstrap, partition TTL).
I just don't want to keep it open, then devs can start mis-using it. and it
may not really worth the effort we took now to deprecate the auto commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
