danny0405 commented on code in PR #13229:
URL: https://github.com/apache/hudi/pull/13229#discussion_r2077188112
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/UpgradeDowngradeUtils.java:
##########
@@ -91,7 +92,8 @@ public static void runCompaction(HoodieTable table,
HoodieEngineContext context,
try (BaseHoodieWriteClient writeClient =
upgradeDowngradeHelper.getWriteClient(compactionConfig, context)) {
Option<String> compactionInstantOpt =
writeClient.scheduleCompaction(Option.empty());
if (compactionInstantOpt.isPresent()) {
- writeClient.compact(compactionInstantOpt.get());
+ HoodieWriteMetadata result =
writeClient.compact(compactionInstantOpt.get());
+ writeClient.commitCompaction(compactionInstantOpt.get(), result,
Option.empty());
Review Comment:
It's okay if we put the default inline flag as false, if the caller wants to
inline compaction for some scenarios, they must specify it as explicit
`true`(shouldComplete).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
