nsivabalan commented on code in PR #13229:
URL: https://github.com/apache/hudi/pull/13229#discussion_r2076682177
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/metadata/FlinkHoodieBackedTableMetadataWriter.java:
##########
@@ -199,6 +199,18 @@ protected HoodieData<HoodieRecord>
getExpressionIndexRecords(List<Pair<String, P
throw new HoodieNotSupportedException("Flink metadata table does not
support expression index yet.");
}
+ protected void bulkInsertAndCommit(BaseHoodieWriteClient<?,
List<HoodieRecord>, ?, List<WriteStatus>> writeClient, String instantTime,
List<HoodieRecord> preppedRecordInputs,
+ Option<BulkInsertPartitioner>
bulkInsertPartitioner) {
+ List<WriteStatus> writeStatusJavaRDD =
writeClient.bulkInsertPreppedRecords(preppedRecordInputs, instantTime,
bulkInsertPartitioner);
+ writeClient.commit(instantTime, writeStatusJavaRDD);
Review Comment:
We might use prepped APIs in spark-sql writer flows for data table as well.
So, don't wanna special case bcoz of that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
