lokeshj1703 commented on code in PR #13229:
URL: https://github.com/apache/hudi/pull/13229#discussion_r2067161543
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/testutils/SparkClientFunctionalTestHarness.java:
##########
@@ -332,9 +330,9 @@ protected void
updateRecordsInMORTable(HoodieTableMetaClient metaClient, List<Ho
List<WriteStatus> statuses = statusesRdd.collect();
// Verify there are no errors
assertNoWriteErrors(statuses);
- if (doExplicitCommit) {
- client.commit(commitTime, statusesRdd);
- }
+ //if (doExplicitCommit) {
Review Comment:
Addressed
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestMORDataSourceStorage.scala:
##########
@@ -190,6 +190,11 @@ class TestMORDataSourceStorage extends
SparkClientFunctionalTestHarness {
// compaction should have been completed
val metaClient = HoodieTestUtils.createMetaClient(new
HadoopStorageConfiguration(fs.getConf), basePath)
assertEquals(1,
metaClient.getActiveTimeline.getCommitAndReplaceTimeline.countInstants())
+
+ val hudiDF2 =
spark.read.format("org.apache.hudi").option("hoodie.metadata.enable","true")
Review Comment:
Addressed
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestMORDataSourceStorage.scala:
##########
@@ -166,7 +166,7 @@ class TestMORDataSourceStorage extends
SparkClientFunctionalTestHarness {
val inputDF1: Dataset[Row] =
spark.read.json(spark.sparkContext.parallelize(records1, 2))
inputDF1.write.format("org.apache.hudi")
.options(options)
- .option(DataSourceWriteOptions.OPERATION.key,
DataSourceWriteOptions.INSERT_OPERATION_OPT_VAL)
+ .option(DataSourceWriteOptions.OPERATION.key,
DataSourceWriteOptions.UPSERT_OPERATION_OPT_VAL)
Review Comment:
Addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
