lokeshj1703 commented on code in PR #13229:
URL: https://github.com/apache/hudi/pull/13229#discussion_r2067161208
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/utils/HoodieWriterClientTestHarness.java:
##########
@@ -297,17 +300,27 @@ protected Object castWriteBatch(BaseHoodieWriteClient
client, String newCommitTi
Function2<List<HoodieRecord>, String,
Integer> recordGenFunction,
Function3<Object, BaseHoodieWriteClient,
Object, String> writeFn,
boolean assertForCommit, int
expRecordsInThisCommit, int expTotalRecords,
- int expTotalCommits, boolean doCommit,
InstantGenerator instantGenerator) throws Exception {
+ int expTotalCommits, InstantGenerator
instantGenerator) throws Exception {
return castWriteBatch(client, newCommitTime, prevCommitTime,
commitTimesBetweenPrevAndNew, initCommitTime, numRecordsInThisCommit,
recordGenFunction,
- writeFn, assertForCommit, expRecordsInThisCommit, expTotalRecords,
expTotalCommits, doCommit, true, instantGenerator);
+ writeFn, assertForCommit, expRecordsInThisCommit, expTotalRecords,
expTotalCommits, true, instantGenerator);
}
protected Object castWriteBatch(BaseHoodieWriteClient client, String
newCommitTime, String prevCommitTime,
Option<List<String>>
commitTimesBetweenPrevAndNew, String initCommitTime, int numRecordsInThisCommit,
Function2<List<HoodieRecord>, String,
Integer> recordGenFunction,
Function3<Object, BaseHoodieWriteClient,
Object, String> writeFn,
- boolean assertForCommit, int
expRecordsInThisCommit, int expTotalRecords, int expTotalCommits, boolean
doCommit,
+ boolean assertForCommit, int
expRecordsInThisCommit, int expTotalRecords, int expTotalCommits,
boolean filterForCommitTimeWithAssert,
InstantGenerator instantGenerator) throws Exception {
+ return castWriteBatch(client, newCommitTime, prevCommitTime,
commitTimesBetweenPrevAndNew, initCommitTime, numRecordsInThisCommit,
recordGenFunction,
+ writeFn, assertForCommit, expRecordsInThisCommit, expTotalRecords,
expTotalCommits, filterForCommitTimeWithAssert, instantGenerator, false);
+ }
+
+ protected Object castWriteBatch(BaseHoodieWriteClient client, String
newCommitTime, String prevCommitTime,
+ Option<List<String>>
commitTimesBetweenPrevAndNew, String initCommitTime, int numRecordsInThisCommit,
+ Function2<List<HoodieRecord>, String,
Integer> recordGenFunction,
+ Function3<Object, BaseHoodieWriteClient,
Object, String> writeFn,
+ boolean assertForCommit, int
expRecordsInThisCommit, int expTotalRecords, int expTotalCommits,
+ boolean filterForCommitTimeWithAssert,
InstantGenerator instantGenerator, boolean leaveInflightCommit) throws
Exception {
Review Comment:
Addressed
##########
hudi-client/hudi-java-client/src/test/java/org/apache/hudi/client/functional/TestHoodieJavaClientOnCopyOnWriteStorage.java:
##########
@@ -111,11 +111,11 @@ protected Object castWriteBatch(BaseHoodieWriteClient
client, String newCommitTi
Option<List<String>>
commitTimesBetweenPrevAndNew, String initCommitTime, int numRecordsInThisCommit,
Function2<List<HoodieRecord>, String,
Integer> recordGenFunction,
Function3<Object, BaseHoodieWriteClient,
Object, String> writeFn,
- boolean assertForCommit, int
expRecordsInThisCommit, int expTotalRecords, int expTotalCommits, boolean
doCommit,
- boolean filterForCommitTimeWithAssert,
InstantGenerator instantGenerator) throws Exception {
+ boolean assertForCommit, int
expRecordsInThisCommit, int expTotalRecords, int expTotalCommits,
+ boolean filterForCommitTimeWithAssert,
InstantGenerator instantGenerator, boolean leaveInflightCommit) throws
Exception {
Review Comment:
Addressed
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/functional/TestHoodieClientOnCopyOnWriteStorage.java:
##########
@@ -685,16 +686,27 @@ public void testDeletesForInsertsInSameBatch() throws
Exception {
super.testDeletesForInsertsInSameBatch(INSTANT_GENERATOR);
}
+ private Pair<JavaRDD<WriteStatus>, List<HoodieRecord>>
insertBatchRecords(SparkRDDWriteClient client, String commitTime,
+
Integer recordNum, int expectStatusSize, int numSlices,
+
Function3<JavaRDD<WriteStatus>, SparkRDDWriteClient, JavaRDD<HoodieRecord>,
String> writeFn) throws IOException {
+ return insertBatchRecords(client, commitTime, recordNum, expectStatusSize,
numSlices, writeFn, false);
+ }
+
private Pair<JavaRDD<WriteStatus>, List<HoodieRecord>>
insertBatchRecords(SparkRDDWriteClient client, String commitTime,
Integer recordNum, int expectStatusSize, int numSlices,
-
Function3<JavaRDD<WriteStatus>, SparkRDDWriteClient, JavaRDD<HoodieRecord>,
String> writeFn) throws IOException {
+
Function3<JavaRDD<WriteStatus>, SparkRDDWriteClient, JavaRDD<HoodieRecord>,
String> writeFn,
+
boolean leaveInflightCommit) throws IOException {
Review Comment:
Addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
