the-other-tim-brown commented on code in PR #13208:
URL: https://github.com/apache/hudi/pull/13208#discussion_r2060299154
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/common/SparkReaderContextFactory.java:
##########
@@ -88,6 +90,9 @@ class SparkReaderContextFactory implements
ReaderContextFactory<InternalRow> {
// Spark parquet reader has to be instantiated on the driver and broadcast
to the executors
SparkParquetReader parquetFileReader =
sparkAdapter.createParquetFileReader(false, sqlConf, options, configs);
parquetReaderBroadcast = jsc.broadcast(parquetFileReader);
+ // Broadcast: TableConfig.
+ HoodieTableConfig tableConfig = metaClient.getTableConfig();
Review Comment:
The `SerializableConfiguration` is just the hadoop and IO focused props. The
table config is more focused on the configuration of the table so I don't think
it is wise to mix these. It is better to be intentional here.
The other option is to have the factory take in a `HoodieTableConfig` or
properties. This is what I originally had but it was recommended to do it this
way by @yihua
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
