danny0405 commented on code in PR #13208:
URL: https://github.com/apache/hudi/pull/13208#discussion_r2059423683
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/common/SparkReaderContextFactory.java:
##########
@@ -88,6 +90,9 @@ class SparkReaderContextFactory implements
ReaderContextFactory<InternalRow> {
// Spark parquet reader has to be instantiated on the driver and broadcast
to the executors
SparkParquetReader parquetFileReader =
sparkAdapter.createParquetFileReader(false, sqlConf, options, configs);
parquetReaderBroadcast = jsc.broadcast(parquetFileReader);
+ // Broadcast: TableConfig.
+ HoodieTableConfig tableConfig = metaClient.getTableConfig();
Review Comment:
The `HoodieFileGroupReader.props` already contains all the write-config
options plus the table-config options, we can utilize that once the key gen
related logic been moved to the `HoodieFileGroupReader`.
Also we already have the broadcasted `SerializableConfiguration`, can we
just set all the table options there and reuse it, just like what we do in
`HoodieFileGroupReader`: one props to cover all the config options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
