the-other-tim-brown commented on code in PR #13213:
URL: https://github.com/apache/hudi/pull/13213#discussion_r2058478341
##########
hudi-common/src/main/java/org/apache/hudi/common/engine/HoodieReaderContext.java:
##########
@@ -285,6 +277,14 @@ public abstract HoodieRecord<T>
constructHoodieRecord(Option<T> recordOption,
*/
public abstract T seal(T record);
+ /**
+ * Convert engine specific row into binary format.
+ *
+ * @param record The engine row
+ * @return row with binary format
+ */
+ public abstract T toBinaryRow(T record);
Review Comment:
We can also make this the responsibility of the merger though to return an
optimal representation. If the merger returns an avro, we will run it through
the same conversion code used when reading the log files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
