yihua commented on code in PR #13213:
URL: https://github.com/apache/hudi/pull/13213#discussion_r2057938825
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/FileGroupRecordBuffer.java:
##########
@@ -605,18 +582,15 @@ protected boolean hasNextBaseRecord(T baseRecord,
Pair<Option<T>, Map<String, Ob
return true;
}
- protected boolean hasNextLogRecord() throws IOException {
+ protected boolean hasNextLogRecord() {
if (logRecordIterator == null) {
logRecordIterator = records.values().iterator();
}
while (logRecordIterator.hasNext()) {
- Pair<Option<T>, Map<String, Object>> nextRecordInfo =
logRecordIterator.next();
- Option<T> resultRecord;
- resultRecord = merge(Option.empty(), Collections.emptyMap(),
- nextRecordInfo.getLeft(), nextRecordInfo.getRight());
- if (resultRecord.isPresent()) {
- nextRecord = readerContext.seal(resultRecord.get());
+ BufferedRecord<T> nextRecordInfo = logRecordIterator.next();
+ if (!nextRecordInfo.isDelete()) {
+ nextRecord = readerContext.seal(nextRecordInfo.getRecord());
Review Comment:
There is no need to seal the record fetched from the `records` map.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
