codope commented on code in PR #13212:
URL: https://github.com/apache/hudi/pull/13212#discussion_r2056446378


##########
hudi-common/src/main/java/org/apache/hudi/metadata/SecondaryIndexRecordGenerationUtils.java:
##########
@@ -176,6 +176,25 @@ private static Map<String, String> 
getRecordKeyToSecondaryKey(HoodieTableMetaCli
                                                                 
Option<StoragePath> dataFilePath,
                                                                 
HoodieIndexDefinition indexDefinition,
                                                                 String 
instantTime) throws Exception {
+    HoodieFileSliceReader fileSliceReader =

Review Comment:
   +1 for closing it after the iterator is consumed after while loop.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to