the-other-tim-brown commented on code in PR #13212:
URL: https://github.com/apache/hudi/pull/13212#discussion_r2056410360
##########
hudi-common/src/main/java/org/apache/hudi/metadata/SecondaryIndexRecordGenerationUtils.java:
##########
@@ -207,19 +226,8 @@ private static Map<String, String>
getRecordKeyToSecondaryKey(HoodieTableMetaCli
if (dataFilePath.isPresent()) {
baseFileReader =
Option.of(HoodieIOFactory.getIOFactory(metaClient.getStorage()).getReaderFactory(recordMerger.getRecordType()).getFileReader(getReaderConfigs(storageConf),
dataFilePath.get()));
Review Comment:
This reader is never getting closed and it will lead to leaks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
