yihua commented on code in PR #13171:
URL: https://github.com/apache/hudi/pull/13171#discussion_r2054526122
##########
hudi-hadoop-common/src/test/java/org/apache/hudi/common/table/read/TestOverwriteWithLatestMerger.java:
##########
@@ -126,73 +118,78 @@ public void initialize() throws Exception {
public void testWithOneLogFile(boolean useRecordPositions) throws
IOException, InterruptedException {
shouldWritePositions = Arrays.asList(useRecordPositions,
useRecordPositions);
// The FileSlice contains a base file and a log file.
- ClosableIterator<IndexedRecord> iterator = getFileGroupIterator(2,
useRecordPositions);
- List<String> leftKeysExpected = Arrays.asList("6", "7", "8", "9", "10");
- List<Long> leftTimestampsExpected = Arrays.asList(2L, 2L, 2L, 2L, 2L);
- List<String> leftKeysActual = new ArrayList<>();
- List<Long> leftTimestampsActual = new ArrayList<>();
- while (iterator.hasNext()) {
- IndexedRecord record = iterator.next();
-
leftKeysActual.add(record.get(AVRO_SCHEMA.getField(ROW_KEY).pos()).toString());
- leftTimestampsActual.add((Long)
record.get(AVRO_SCHEMA.getField("timestamp").pos()));
+ try (ClosableIterator<IndexedRecord> iterator = getFileGroupIterator(2,
useRecordPositions)) {
+ List<String> leftKeysExpected = Arrays.asList("6", "7", "8", "9", "10");
+ List<Long> leftTimestampsExpected = Arrays.asList(2L, 2L, 2L, 2L, 2L);
+ List<String> leftKeysActual = new ArrayList<>();
+ List<Long> leftTimestampsActual = new ArrayList<>();
+ while (iterator.hasNext()) {
+ IndexedRecord record = iterator.next();
+
leftKeysActual.add(record.get(AVRO_SCHEMA.getField(ROW_KEY).pos()).toString());
+ leftTimestampsActual.add((Long)
record.get(AVRO_SCHEMA.getField("timestamp").pos()));
+ }
+ assertEquals(leftKeysExpected, leftKeysActual);
+ assertEquals(leftTimestampsExpected, leftTimestampsActual);
}
- assertEquals(leftKeysExpected, leftKeysActual);
- assertEquals(leftTimestampsExpected, leftTimestampsActual);
}
@ParameterizedTest
@ValueSource(booleans = {true, false})
public void testWithTwoLogFiles(boolean useRecordPositions) throws
IOException, InterruptedException {
shouldWritePositions = Arrays.asList(useRecordPositions,
useRecordPositions, useRecordPositions);
// The FileSlice contains a base file and two log files.
- ClosableIterator<IndexedRecord> iterator = getFileGroupIterator(3,
useRecordPositions);
- List<String> leftKeysExpected = Arrays.asList("1", "2", "3", "6", "7",
"8", "9", "10");
- List<Long> leftTimestampsExpected = Arrays.asList(1L, 1L, 1L, 2L, 2L, 2L,
2L, 2L);
- List<String> leftKeysActual = new ArrayList<>();
- List<Long> leftTimestampsActual = new ArrayList<>();
- while (iterator.hasNext()) {
- IndexedRecord record = iterator.next();
-
leftKeysActual.add(record.get(AVRO_SCHEMA.getField(ROW_KEY).pos()).toString());
- leftTimestampsActual.add((Long)
record.get(AVRO_SCHEMA.getField("timestamp").pos()));
+ try (ClosableIterator<IndexedRecord> iterator = getFileGroupIterator(3,
useRecordPositions)) {
+ List<String> leftKeysExpected = Arrays.asList("1", "2", "3", "6", "7",
"8", "9", "10");
+ List<Long> leftTimestampsExpected = Arrays.asList(1L, 1L, 1L, 2L, 2L,
2L, 2L, 2L);
+ List<String> leftKeysActual = new ArrayList<>();
+ List<Long> leftTimestampsActual = new ArrayList<>();
+ while (iterator.hasNext()) {
+ IndexedRecord record = iterator.next();
+
leftKeysActual.add(record.get(AVRO_SCHEMA.getField(ROW_KEY).pos()).toString());
+ leftTimestampsActual.add((Long)
record.get(AVRO_SCHEMA.getField("timestamp").pos()));
+ }
+ assertEquals(leftKeysExpected, leftKeysActual);
+ assertEquals(leftTimestampsExpected, leftTimestampsActual);
}
- assertEquals(leftKeysExpected, leftKeysActual);
- assertEquals(leftTimestampsExpected, leftTimestampsActual);
}
@ParameterizedTest
@ValueSource(booleans = {true, false})
public void testWithThreeLogFiles(boolean useRecordPositions) throws
IOException, InterruptedException {
shouldWritePositions = Arrays.asList(useRecordPositions,
useRecordPositions, useRecordPositions, useRecordPositions);
// The FileSlice contains a base file and three log files.
- ClosableIterator<IndexedRecord> iterator = getFileGroupIterator(4,
useRecordPositions);
- List<String> leftKeysExpected = Arrays.asList("1", "2", "3", "9", "10");
- List<Long> leftTimestampsExpected = Arrays.asList(1L, 1L, 1L, 2L, 2L);
- List<String> leftKeysActual = new ArrayList<>();
- List<Long> leftTimestampsActual = new ArrayList<>();
- while (iterator.hasNext()) {
- IndexedRecord record = iterator.next();
-
leftKeysActual.add(record.get(AVRO_SCHEMA.getField(ROW_KEY).pos()).toString());
- leftTimestampsActual.add((Long)
record.get(AVRO_SCHEMA.getField("timestamp").pos()));
+ try (ClosableIterator<IndexedRecord> iterator = getFileGroupIterator(4,
useRecordPositions)) {
+ List<String> leftKeysExpected = Arrays.asList("1", "2", "3", "9", "10");
+ List<Long> leftTimestampsExpected = Arrays.asList(1L, 1L, 1L, 2L, 2L);
+ List<String> leftKeysActual = new ArrayList<>();
+ List<Long> leftTimestampsActual = new ArrayList<>();
+ while (iterator.hasNext()) {
+ IndexedRecord record = iterator.next();
+
leftKeysActual.add(record.get(AVRO_SCHEMA.getField(ROW_KEY).pos()).toString());
+ leftTimestampsActual.add((Long)
record.get(AVRO_SCHEMA.getField("timestamp").pos()));
+ }
+ assertEquals(leftKeysExpected, leftKeysActual);
+ assertEquals(leftTimestampsExpected, leftTimestampsActual);
}
- assertEquals(leftKeysExpected, leftKeysActual);
- assertEquals(leftTimestampsExpected, leftTimestampsActual);
}
@Test
public void testWithFourLogFiles() throws IOException, InterruptedException {
+ shouldWritePositions = Arrays.asList(false, false, false, false, false);
Review Comment:
https://github.com/apache/hudi/pull/13171#discussion_r2054525263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
